Add feature: delete car #132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix/resolve security advisories
New endpoint: `/versions.json` Returns object which contains (for now) one field which is the current version of the backend.
* Added new endpoint to change password * Small improvements in logging * Added first prototype for an authentication service * Added utility function to create a router for handling validations * Added missing properties to db config which could lead to a broken database configuration * Changed UserNotFoundError to also accept username * Added findByUsername and findById to UserRepository * Added utility function to bind arguments to debug logging functions * Adapt to name change of bcrypt to auth * Added default environment vars to db.yml * Added .env to dockerignore and added empty .env to docker image * Added email to Express.User * Small changes to Database class * Changed convertUserToJWTPayload to accept UserDto * Added checkPassword and changePassword methods to UserService * Added service.ts in which common types for all services are defined * Added index file for auth folder * Improved SignUpController to use async/await * Aggregated validators for user properties into own file * Removed link from docker-compose.dev.yml to tmp folder of host * Changed default port to 8000 * Changed test database to be groupcarapitest * Made deletedAt in Express.User optional * Added test utility function for easier integration test setup * Fixed incorrect handling of transaction in signUpController
* Extracted path parameters into own general components in openapi specification * Added openapi specification of new endpoint to openapi.yaml * Added better specification of possible errors for new endpoint * Refactored validators to be more consistent * Refactored how custom validators are implemented * Added repository method to delete a car * Small fixes of the documentation of MembershipService.findById * Added Delete action to GroupNotificationService * Added service method to delete a car * Completed new endpoint to delete a car * Added unit tests * Added integration tests * Added detailed documentation to MembershipService.findById * Fixed incorrect error documentation of new endpoint * Cleaned some code * Fixed codefactor issues * v0.9.0-alpha.0 * Disable x-powered-by * v0.9.0-alpha.1
# Conflicts: # app/routes/api/user/settings/change-password/index.ts # app/routes/auth/signUp/sign-up-validator.ts # app/validators/create-validation-router.ts # app/validators/user-id-validator.ts # app/validators/user-validators.ts # package.json # static/versions.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.