8000 kernel: Optimize display format for auto init when debugging by unicornx · Pull Request #9705 · RT-Thread/rt-thread · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
/ rt-thread Public

kernel: Optimize display format for auto init when debugging #9705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 27, 2024
Merged

kernel: Optimize display format for auto init when debugging #9705

merged 1 commit into from
Nov 27, 2024

Conversation

unicornx
Copy link
Contributor

Fixed #9671

When RT_DEBUGING_AUTO_INIT is enabled, kenrel will add more print message for auto init. However, the original format easily causes the kernel printing and the init function printing to be connected together, resulting in a confusing display format.

For exmaple:

initialize lwip_system_initlwIP-2.0.3 initialized!
:0 done

Or

initialize sal_init[I/sal.skt] Socket Abstraction Layer initialize success.
:0 done

Solution: Add a carriage return to separate the kernel printing and the init function printing.

After changing, the output will be:

initialize lwip_system_init
lwIP-2.0.3 initialized!
:0 done

Or

initialize sal_init
[I/sal.skt] Socket Abstraction Layer initialize success.
:0 done

一个更好的的 screen scratch

修改前：
image

修改后：
image

拉取/合并请求描述：(PR description)

[

为什么提交这份PR (why to submit this PR)

你的解决方案是什么 (what is your solution)

请提供验证的bsp和config (provide the config and bsp)

  • BSP:
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality：

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确，包括缩进空格，命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码，代码尽量精简，不包含#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的，并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/workflows/bsp_buildings.yml 详细请参考链接BSP自查

@unicornx
kernel: Optimize display format for auto init when debugging
00e0601 
When RT_DEBUGING_AUTO_INIT is enabled, kenrel will add more
print message for auto init. However, the original format
easily causes the kernel printing and the init function printing
to be connected together, resulting in a confusing display
format.

For exmaple:
```
initialize lwip_system_initlwIP-2.0.3 initialized!
:0 done
```
Or
```
initialize sal_init[I/sal.skt] Socket Abstraction Layer initialize success.
:0 done
```

Solution: Add a carriage return to separate the kernel
printing and the init function printing.

After changing, the output will be:
```
initialize lwip_system_init
lwIP-2.0.3 initialized!
:0 done
```
Or
```
initialize sal_init
[I/sal.skt] Socket Abstraction Layer initialize success.
:0 done
```

Signed-off-by: Chen Wang <unicorn_wang@outlook.com>
@github-actions github-actions bot added the Kernel PR has src relate code label Nov 26, 2024
@unicornx unicornx self-assigned this Nov 26, 2024
@BernardXiong
Copy link
Member

我记得早期linux的boot打印信息会是输出绿色的 ... [OK]，然后中间出问题也会c出现乱的情况

@mysterywolf mysterywolf merged commit c4ba5ee into RT-Thread:master Nov 27, 2024
45 checks passed
@unicornx unicornx mentioned this pull request Dec 9, 2024
Closed
10 tasks
@unicornx unicornx deleted the dev-9671 branch December 17, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mysterywolf mysterywolf mysterywolf approved these changes

Assignees

@unicornx unicornx

Labels
Kernel PR has src relate code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] print format looks werid when RT_DEBUGING_AUTO_INIT is open
3 participants
@unicornx @BernardXiong @mysterywolf
0