8000 [tools]Fix project compilation errors generated by mdk and iar by Rbb666 · Pull Request #8579 · RT-Thread/rt-thread · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[tools]Fix project compilation errors generated by mdk and iar #8579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 6, 2024
Merged

[tools]Fix project compilation errors generated by mdk and iar #8579

merged 1 commit into from
Mar 6, 2024

Conversation

Rbb666
Copy link
Member
@Rbb666 Rbb666 commented Mar 4, 2024

拉取/合并请求描述：(PR description)

修复mdk和iar生成工程时不添加__RT_KERNEL_SOURCE__宏导致的编译报错，以及修复一些编译警告

[

为什么提交这份PR (why to submit this PR)

你的解决方案是什么 (what is your solution)

请提供验证的bsp和config (provide the config and bsp)

  • BSP:
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality：

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确，包括缩进空格，命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码，代码尽量精简，不包含#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的，并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification

@Rbb666 Rbb666 requested review from Guozhanxin and mysterywolf March 4, 2024 10:08
@BernardXiong BernardXiong requested a review from polarvid March 5, 2024 02:23
@BernardXiong
Copy link
Member

@polarvid 这个是之前的CTX代码引入的问题，需要评估下这样修改是否没问题。

@Rbb666
Copy link
Member Author
Rbb666 commented Mar 5, 2024

@polarvid 这个是之前的CTX代码引入的问题，需要评估下这样修改是否没问题。

这笔PR可以理解给 #8537 PR引出的MDK/IAR编译问题打了个补丁。

mysterywolf
mysterywolf requested changes Mar 5, 2024
View reviewed changes
Copy link
Member
@mysterywolf mysterywolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI有错误

@Rbb666
Copy link
Member Author
Rbb666 commented Mar 5, 2024

CI有错误

不同工具链对这块的编译行为都不同，加上;MDK会报一堆警告，删除smart那边编译不通过
image

@mysterywolf mysterywolf merged commit d31c05a into RT-Thread:master Mar 6, 2024
@Rbb666 Rbb666 deleted the mdk_iar branch April 19, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mysterywolf mysterywolf mysterywolf approved these changes

@polarvid polarvid polarvid approved these changes

54BC @Guozhanxin Guozhanxin Awaiting requested review from Guozhanxin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Rbb666 @BernardXiong @mysterywolf @polarvid
0