8000 Add NPS4 support on some models by wenkaidu · Pull Request #256 · ROCm/rccl · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add NPS4 support on some models #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 19, 2020
Merged

Add NPS4 support on some models #256

merged 2 commits into from
Aug 19, 2020

Conversation

wenkaidu
Copy link
Collaborator

No description provided.

Copy link
Collaborator
@gilbertlee-amd gilbertlee-amd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This detection code is getting quite complicated.
Would it be possible to pull it out into a different file for easier maintenance / merging?

@wenkaidu
Copy link
Collaborator Author

This detection code is getting quite complicated.
Would it be possible to pull it out into a different file for easier maintenance / merging?

Yes, I am thinking about a plug-in to make it cleaner and less likely to break existing models

@wenkaidu wenkaidu merged commit 391bbf3 into ROCm:develop Aug 19, 2020
@wenkaidu wenkaidu deleted the rome branch August 19, 2020 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0