8000 Don't link against libamd_comgr.so at runtime by Mystro256 · Pull Request #158 · ROCm/clr · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Don't link against libamd_comgr.so at runtime #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: amd-staging
Choose a base branch
from
Open

Don't link against libamd_comgr.so at runtime #158

wants to merge 1 commit into from

Conversation

Mystro256
Copy link
Contributor
@Mystro256 Mystro256 commented May 1, 2025 •
edited
Loading

Convention is to always link against .so.* at runtime. Having it link against .so will break on systems that package the .so files in their dev/devel package.

This issue was found when building ROCm 6.4 for Fedora.

@Mystro256
Don't link against libamd_comgr.so at runtime
d508111 
Convention is to always link against .so.* at runtime. Having it link
against .so will break on systems that package the .so files in their
dev/devel package.
@Mystro256
Copy link
Contributor Author

@lamb-j git blame pointed me to your patch: 1876484

@Mystro256 Mystro256 requested a review from lamb-j May 1, 2025 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lamb-j lamb-j Awaiting requested review from lamb-j

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Mystro256
0