Improved parsing of Router Certificates #95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lolepezy
approved these changes
Oct 28, 2021
src/main/java/net/ripe/rpki/commons/crypto/x509cert/X509CertificateParser.java
Outdated
Show resolved
Hide resolved
src/main/java/net/ripe/rpki/commons/crypto/x509cert/X509CertificateParser.java
Outdated
Show resolved
Hide resolved
|
Tests also need to be revisited. Part of the cases appear to be copied from resource certificates. |
Partial implementation of the checks for router certificates in [0]. TO DO: check that AS resources are not inherited. [0]: https://datatracker.ietf.org/doc/html/rfc8209
252f8ea to
c0f7709
Compare
ddccaeb to
4f4c298
Compare
src/main/java/net/ripe/rpki/commons/crypto/x509cert/X509RouterCertificateParser.java
Outdated
Show resolved
Hide resolved
lolepezy
approved these changes
Jul 6, 2022
|
@erikrozendaal the public key validation should now be there. It is a bit more detail than I wanted, but it is in spec, and can not be validated through the java api. The adjustments to the test harness (probably best to look at just the final two commits) feel a bit clumsy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial implementation of the checks for router certificates in 0.
TO DO: check that AS resources are not inherited.
(Was reviewing code while reading part of the spec and while looking at objects)