-
Notifications
You must be signed in to change notification settings - Fork 2.1k
tests/pkg/relic: add Paillier encryption tests #21301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests/pkg/relic: add Paillier encryption tests #21301
Conversation
3375a2d
to
9c9bb92
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor nit, otherwise looks good. Thanks!
|
9c9bb92
to
c1ec586
Compare
@mguetschow thanks for hint, but ... We can merge this PR with 512-bits (current version) or I could change it to 1024-bits. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then I'd say it's fine to merge like it is. Maybe open an issue instead so we have a reminder to look into it.
I investigate the issue once again - and |
Contribution description
This PR adds two tests to Relic library, concerning Paillier encryption:
Unfortunately, currently only 512 bit Paillier encryption works - in following weeks I try to figure out why longer keys leads to stack smashing. I tested native with 256 MiB of memory and stack smashing error appears.Using big enough
BN_PRECI
inRELIC_CONFIG_FLAGS
and appropriate stack size allows usage of longer keys.With
BN_PRECI=4096
and stack size with 114688 bytes onnative
- Paillier keys 1024 and 2048 bits works.Testing procedure
Run
tests/pkg/relic
and check if all tests are successful.Issues/PRs references
None