8000 docs/rust: Install c2rust with --locked by chrysn · Pull Request #21236 · RIOT-OS/RIOT · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

docs/rust: Install c2rust with --locked #21236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 21, 2025

Conversation

chrysn
Copy link
Member
@chrysn chrysn commented Feb 21, 2025

Contribution description

A newer version of a library broke c2rust (dtolnay/proc-macro2#475 is the proc-macro issue, immunant/c2rust#1197 is how c2rust fixed it, but they don't have a new release yet). Until then, using --locked is a viable path.

Testing procedure

  • Reinstall c2rust
  • Any Rust example can still (or, if you recently installed c2rust, now) be built.

Issues/PRs references

Closes: #21079

@chrysn chrysn requested a review from mguetschow February 21, 2025 13:30
@github-actions github-actions bot added the Area: doc Area: Documentation label Feb 21, 2025
@mguetschow mguetschow added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Feb 21, 2025
@riot-ci
Copy link
riot-ci commented Feb 21, 2025

Murdock results

✔️ PASSED

31c4547 docs/rust: Install c2rust with --locked

Success Failures Total Runtime
1 0 1 01m:19s

Artifacts

Copy link
Contributor
@mguetschow mguetschow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed to fix the issue locally. Thanks for investigating!

@mguetschow mguetschow enabled auto-merge February 21, 2025 13:41
@mguetschow mguetschow added this pull request to the merge queue Feb 21, 2025
Merged via the queue into RIOT-OS:master with commit dcdf6a2 Feb 21, 2025
27 checks passed
@chrysn chrysn deleted the doc-c2rust-locked branch February 21, 2025 13:47
@mguetschow mguetschow added this to the Release 2025.04 milestone Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: doc Area: Documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rust examples fail to build in local environment
3 participants
0