8000 drivers/periph_init: initialize watchdog first by benpicco · Pull Request #21025 · RIOT-OS/RIOT · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

drivers/periph_init: initialize watchdog first #21025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8000 Jump to bottom
Merged
merged 1 commit into from
Nov 22, 2024
Merged

drivers/periph_init: initialize watchdog first #21025

merged 1 commit into from
Nov 22, 2024

Conversation

benpicco
Copy link
Contributor
@benpicco benpicco commented Nov 21, 2024 •
edited
Loading

Contribution description

We want to initialize the watchdog early so it can detect a hang in later init functions.

Testing procedure

I flashed examples/gnrc_networking with periph_wdt_auto_start on same54-xpro.
We still reach main() (and reset a bit after that because I didn't service the watchdog)

2024-11-21 16:34:40,149 # main(): This is RIOT! (Version: 2025.01-devel-150-g220d10-drivers/wdt-early_init)
2024-11-21 16:34:40,152 # RIOT network stack example application
2024-11-21 16:34:40,155 # All up, running the shell now
>

Issues/PRs references

@github-actions github-actions bot added the Area: drivers Area: Device drivers label Nov 21, 2024
@benpicco
drivers/periph_init: initialize watchdog first
220d100 
We want to initialize the watchdog early so it can detect a hang in
later init functions.
@benpicco benpicco force-pushed the drivers/wdt-early_init branch from 4becb24 to 220d100 Compare November 21, 2024 15:28
@benpicco benpicco changed the title drivers/periph_wdt: initialize watchdog first drivers/periph_init: initialize watchdog first Nov 21, 2024
@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Nov 21, 2024
@benpicco benpicco requested a review from maribu November 21, 2024 19:13
@riot-ci
Copy link
riot-ci commented Nov 21, 2024

Murdock results

✔️ PASSED

220d100 drivers/periph_init: initialize watchdog first

Success Failures Total Runtime
10249 0 10249 15m:12s

Artifacts

@benpicco benpicco added this pull request to the merge queue Nov 21, 2024
@maribu maribu removed this pull request from the merge queue due to a manual request Nov 21, 2024
@maribu maribu added this pull request to the merge queue Nov 21, 2024
Enoch247
Enoch247 approved these changes Nov 22, 2024
View reviewed changes
Copy link
Contributor
@Enoch247 Enoch247 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with USEMODULE=periph_wdt_auto_start make -C tests/pkg/lvgl_touch, and works as intended.

Merged via the queue into RIOT-OS:master with commit db33118 Nov 22, 2024
28 checks passed
@benpicco benpicco deleted the drivers/wdt-early_init branch November 22, 2024 11:52
@MrKevinWeiss MrKevinWeiss added this to the Release 2025.01 milestone Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maribu maribu maribu approved these changes

@Enoch247 Enoch247 Enoch247 approved these changes

@MrKevinWeiss MrKevinWeiss Awaiting requested review from MrKevinWeiss MrKevinWeiss is a code owner

@fabian18 fabian18 Awaiting requested review from fabian18

Assignees
No one assigned
Labels
Area: drivers Area: Device drivers CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR
Projects
None yet
Milestone
Release 2025.01
Development

Successfully merging this pull request may close these issues.
5 participants
@benpicco @riot-ci @maribu @Enoch247 @MrKevinWeiss
0