8000 boards/saml1x: convert bitfields to new masks name by dylad · Pull Request #20856 · RIOT-OS/RIOT · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

boards/saml1x: convert bitfields to new masks name #20856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 13, 2024
Merged

boards/saml1x: convert bitfields to new masks name #20856

merged 1 commit into from
Sep 13, 2024

Conversation

dylad
Copy link
Member
@dylad dylad commented Sep 8, 2024

Contribution description

This PR is part of the Microchip vendor files migration.
It only change the needed bitfields to match the new syntax on saml1x-based board.
Strangely, SAML10 and SAML11 are the only MCUs that have both syntaxes inside their vendor files. It's a real shame that it is not the case of the whole ATSAM base...
Thus, these families don't need a compatibility headers for the ongoing migration.

Testing procedure

A quick CI run should be enough. This PR only changes a few bitfields names. Binaries shouldn't be modified.

Issues/PRs references

Part of #20457

@dylad
boards/saml1x: convert bitfields to new masks name
82ce32e 
Signed-off-by: Dylan Laduranty <dylan.laduranty@mesotic.com>
@github-actions github-actions bot added the Area: boards Area: Board ports label Sep 8, 2024
@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Sep 9, 2024
@benpicco
Copy link
Contributor
benpicco commented Sep 9, 2024

Is it possible to instead provide MCLK_APBCMASK_TC0 etc as compat defines so we don't have to modify all (external) boards?

@riot-ci
Copy link
riot-ci commented Sep 9, 2024

Murdock results

✔️ PASSED

82ce32e boards/saml1x: convert bitfields to new masks name

Success Failures Total Runtime
10196 0 10197 12m:49s

Artifacts

@dylad
Copy link
Member Author
dylad commented Sep 9, 2024 •
edited
Loading

Is it possible to instead provide MCLK_APBCMASK_TC0 etc as compat defines so we don't have to modify all (external) boards?

If we could figured out an easy way to script this, I guess so.
However, I do not see more benefits than the current approach.
I do no plan to break external boards (yet). Instead I was planning to add a warning message at compile time to all boards using old vendor files. (+ announcement on the forum, matrix, etc.) Once the whole transition is done on our side. Ask users to kindly migrate their external boards and give them something like 2 releases so they can move on.

The selection of old/new vendor files would be done at boards level using a simple #define FOO_NEW_VENDOR_FILES_BAR
By default, the selection mechanism will default to old vendor files (to not break external boards and ours) Then, introduce per boards this define so it can use new vendor files.

After this delay, I was planning to remove this define and all the old stuff around it including old vendor files.
I think this will give a reasonable time to our users base to migrate their stuff.

Note that the delay can be increased if needed.

@benpicco benpicco added the Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer label Sep 13, 2024
@benpicco benpicco enabled auto-merge September 13, 2024 12:43
@benpicco benpicco added this pull request to the merge queue Sep 13, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 13, 2024
@benpicco benpicco added this pull request to the merge queue Sep 13, 2024
Merged via the queue into RIOT-OS:master with commit 0cea359 Sep 13, 2024
28 checks passed
@dylad dylad deleted the pr/cpu/saml1x/compat_headers branch September 13, 2024 20:21
@dylad
Copy link
Member Author
dylad commented Sep 13, 2024

Thanks !

@benpicco benpicco added this to the Release 2024.10 milestone Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benpicco benpicco benpicco approved these changes

Assignees
No one assigned
Labels
Area: boards Area: Board ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dylad @benpicco @riot-ci
0