dist: tools: avoid hanging tapsetup in the absence of a DHCP server #20411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"Become a daemon immediately (nowait) rather than waiting until an IP address has been acquired." Otherwise tapsetup may hang for a long time in the absence of a DHCP server.
benpicco
previously approved these changes
Feb 22, 2024
|
If this keeps it running beyond the lifetime of the tapbridge, we better kill it on tear-down (before it lays eggs) |
New changes were requested: Missing tear-down of the dhcp service.
|
Has this been addressed anywhere in the mean time? |
maribu
approved these changes
Feb 2, 2025
|
I'll add the tear down as follow up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
"Become a daemon immediately (nowait) rather than waiting until an IP address has been acquired." Otherwise tapsetup may hang for a long time in the absence of a DHCP server.
Testing procedure
Run
tapsetup -u <UPSTREAM-INTERFACE>without a DHCP server ready on that link.