8000 examples/dtls-sock: fix credman capacity by maribu · Pull Request #20217 · RIOT-OS/RIOT · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

examples/dtls-sock: fix credman capacity #20217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

maribu
Copy link
Member
@maribu maribu commented Dec 27, 2023

Contribution description

It should be possible to test DTLS via ::1, but this requires 4 slots in the credman instead of just two.

Testing procedure

Running both server and client on the same app should now succeed; or at least no longer fail when adding the credentials.

Issues/PRs references

Found while testing #20196

@maribu maribu added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Dec 27, 2023
@github-actions github-actions bot added the Area: examples Area: Example Applications label Dec 27, 2023
@riot-ci
Copy link
riot-ci commented Dec 27, 2023

Murdock results

✔️ PASSED

3f57b8c examples/dtls-sock: fix credman capacity

Success Failures Total Runtime
19 0 19 01m:15s

Artifacts

Copy link
Contributor
@fabian18 fabian18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right. Without it we cannot add the credentials.

But somehow the handshake does not work when I test on same54-xpro with Ethernet or with native. The server receives the first hello request but the client seems to be busy with retransmissions (not sure) and the shell is blocked.

2024-01-06 11:58:32,882 # dtlss start
> dtlsc ::1 hello
2024-01-06 11:58:39,295 # dtlsc ::1 hello
2024-01-06 11:58:39,298 # cannot create peer
2024-01-06 11:58:39,301 # error while handling handshake packet
2024-01-06 11:58:39,303 # 80 invalidate peer
2024-01-06 11:58:39,307 # received fatal alert, peer has been invalidated

@maribu
Copy link
Member Author
maribu commented Jan 6, 2024

I had the same issue on AVR :-/ At least we know that this is not an architecture specific issue

It should be possible to test DTLS via `::1`, but this requires 4
slots in the credman instead of just two.
@maribu maribu force-pushed the examples/dtls-sock/credman-capacity branch from bff4269 to 3f57b8c Compare February 15, 2024 11:29
@maribu maribu enabled auto-merge February 15, 2024 11:29
@maribu maribu added this pull request to the merge queue Feb 15, 2024
Merged via the queue into RIOT-OS:master with commit a378c0b Feb 15, 2024
@maribu maribu deleted the examples/dtls-sock/credman-capacity branch March 1, 2024 17:38
@MrKevinWeiss MrKevinWeiss added this to the Release 2024.04 milestone Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: examples Area: Example Applications CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0