8000 cpu/efm32/gpio: use gpio_irq feature by haukepetersen · Pull Request #10000 · RIOT-OS/RIOT · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

cpu/efm32/gpio: use gpio_irq feature #10000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 4, 2018
Merged

cpu/efm32/gpio: use gpio_irq feature #10000

merged 1 commit into from
Oct 4, 2018

Conversation

haukepetersen
Copy link
Contributor

See #9992

@bergzand
Copy link
Member

Number #10000! 🎉

@haukepetersen haukepetersen mentioned this pull request Sep 21, 2018
8000
Merged
16 tasks
@kaspar030
Copy link
Contributor

Number #10000! tada

Happy 10k everyone!!

@haukepetersen
Copy link
Contributor Author

thanks for forcing me to open separate PRs for every CPU - that helped with the numbers :-)

@haukepetersen haukepetersen mentioned this pull request Sep 21, 2018
Closed
20 tasks
@miri64 miri64 added Platform: ARM Platform: This PR/issue effects ARM-based platforms Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation Area: drivers Area: Device drivers labels Sep 27, 2018
@haukepetersen
Copy link
Contributor Author

@basilfx would you mind to give this a quick review/test?! Thanks

@basilfx
Copy link
Member
basilfx commented Oct 4, 2018 •
edited
Loading

I have limited time due to my new house, so maybe @kYc0o can do this one?

(I know it's easy, but I haven't touched my personal notebook since I got the keys :-P)

@haukepetersen
Copy link
Contributor Author

of course, I'll find someone else. Have fun braking the house :-)

kYc0o
kYc0o approved these changes Oct 4, 2018
View reviewed changes
Copy link
Contributor
@kYc0o kYc0o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ACK.

@kYc0o kYc0o added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Oct 4, 2018
@haukepetersen
Copy link
Contributor Author

Murdock pointed out one more issue (unused _pin_mask()) function in case periph_gpio_irq was not used. Fixed and squashed.

@kYc0o kYc0o self-assigned this Oct 4, 2018
@kYc0o kYc0o added this to the Release 2018.10 milestone Oct 4, 2018
@kYc0o kYc0o merged commit 0d52767 into RIOT-OS:master Oct 4, 2018
@kaspar030
Copy link
Contributor

Happy 10k again ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kYc0o kYc0o kYc0o approved these changes

Assignees

@kYc0o kYc0o

Labels
Area: drivers Area: Device drivers CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ARM Platform: This PR/issue effects ARM-based platforms Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Milestone
Release 2018.10
Development

Successfully merging this pull request may close these issues.
6 participants
@haukepetersen @bergzand @kaspar030 @basilfx @kYc0o @miri64
0