nanocoap_sock: don't include token in empty ACK response #19366
8000
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
65436de to
84827a4
Compare
maribu
approved these changes
Mar 8, 2023
There was a problem hiding this comment.
Please update the PR description before starting bors and replace "ACK response" with "empty ACK". "ACK response" would generally be understood as an ACK with a piggybacked response payload, which would need the token.
And empty ACK however MUST NOT have a token; this fixes a severe standard violation. Thx for spotting it
84827a4 to
d6e05da
Compare
|
bors merge |
bors bot
added a commit
that referenced
this pull request
Mar 8, 2023
19366: nanocoap_sock: don't include token in empty ACK response r=benpicco a=benpicco 19367: cord: bump reference from draft to rfc r=benpicco a=bergzand ### Contribution description The draft is an RFC, this bumps the "see also" in the docs to the rfc. ### Testing procedure Check that the correct RFC is linked in the docs. ### Issues/PRs references None Co-authored-by: Benjamin Valentin <benjamin.valentin@ml-pa.com> Co-authored-by: Koen Zandberg <koen@bergzand.net>
|
bors cancel |
|
Canceled. |
|
bors merge |
|
Already running a review |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
CoAP doesn't expect a Token in an empty ACK, but
coap_build_hdr()will copy it over if we give it a token length.This is bad as here we only provide space for the CoAP header
ack.coap_build_hdr()will copy the token intosnipwhere it causes all kinds of mayhem.Testing procedure
Issues/PRs references