8000 sys/vfs: add force option to vfs_umount() by benpicco · Pull Request #19320 · RIOT-OS/RIOT · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

sys/vfs: add force option to vfs_umount() #19320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 28, 2023
Merged

sys/vfs: add force option to vfs_umount() #19320

merged 3 commits into from
Feb 28, 2023

Conversation

benpicco
Copy link
Contributor

Contribution description

Sometimes we need to unmount the file-system now even if there are still open files (e.g. to perform a reboot).

So far this was prevented by a check in vfs_umount() to not allow to unmount a fs if it still has open files.

This adds a force option that will ignore the check and unmount the fs anyway.

Testing procedure

Issues/PRs references

@github-actions github-actions bot added Area: sys Area: System Area: tests Area: tests and testing framework labels Feb 26, 2023
@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Feb 26, 2023
@riot-ci
Copy link

riot-ci commented Feb 26, 2023 •
edited
Loading

Murdock results

✔️ PASSED

2658eb1 tests: test the -EBUSY case for vfs_umount()

Success Failures Total Runtime
6888 0 6888 08m:48s

Artifacts

miri64
miri64 reviewed Feb 28, 2023
View reviewed changes
miri64
miri64 approved these changes Feb 28, 2023
View reviewed changes
Copy link
Member
@miri64 miri64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With my new test, I think this can be ACK'd.

@benpicco
Copy link
Contributor Author

Thank you for providing the test!

@miri64
Copy link
Member
miri64 commented Feb 28, 2023

bors merge

@bors
Copy link
Contributor
bors bot commented Feb 28, 2023

Build succeeded:

@bors bors bot merged commit 4ccf0af into RIOT-OS:master Feb 28, 2023
@benpicco benpicco deleted the vfs_umount-force branch February 28, 2023 19:11
@MrKevinWeiss MrKevinWeiss added this to the Release 2023.04 milestone Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miri64 miri64 miri64 approved these changes

@smlng smlng Awaiting requested review from smlng

@leandrolanzieri leandrolanzieri Awaiting requested review from leandrolanzieri leandrolanzieri is a code owner

@aabadie aabadie Awaiting requested review from aabadie aabadie is a code owner

@MichelRottleuthner MichelRottleuthner Awaiting requested review from MichelRottleuthner MichelRottleuthner is a code owner

@fjmolinas fjmolinas Awaiting requested review from fjmolinas

Assignees
No one assigned
Labels
Area: sys Area: System Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR
Projects
None yet
Milestone
Release 2023.04
Development

Successfully merging this pull request may close these issues.
4 participants
@benpicco @riot-ci @miri64 @MrKevinWeiss
0