8000 vfs: Document that open directories are counted by chrysn · Pull Request #17659 · RIOT-OS/RIOT · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

vfs: Document that open directories are counted #17659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

vfs: Document that open directories are counted #17659

wants to merge 1 commit into from

Conversation

chrysn
Copy link
Member
@chrysn chrysn commented Feb 15, 2022

Contribution description

The addition is helpful because directories are visibly different from
open files (and generally are not treated like files).

Testing procedure

Look at produced documentation

@chrysn
vfs: Document that open directories are counted
4c54bd8 
The addition is helpful because directories are visibly different from
open files (and generally are not treated like files).
@chrysn chrysn added Area: doc Area: Documentation Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Feb 15, 2022
@github-actions github-actions bot added Area: sys Area: System and removed Area: doc Area: Documentation labels Feb 15, 2022
@chrysn chrysn added Area: doc Area: Documentation and removed Area: sys Area: System labels Feb 15, 2022
@chrysn chrysn mentioned this pull request Feb 15, 2022
Merged
@chrysn
Copy link
Member Author
chrysn commented Feb 15, 2022

Closing because it can be treated more easily as bycatch of #17660

@chrysn chrysn closed this Feb 15, 2022
@chrysn chrysn deleted the vfs-minor-wording branch February 15, 2022 14:07
@benpicco
Copy link
Contributor

I'm trying to find where open_files is actually incremented, but in vfs.c it appears to be only decremented - what am I missing here?

@chrysn
Copy link
Member Author
chrysn commented Feb 15, 2022

There is only one add, in _find_mount -- which is finding the right FS, and immediately preventing it from being unmounted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Area: doc Area: Documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chrysn @benpicco
0