Add tests for Pyodide build with Pixi and Node.js #1450
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 15337797521Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #1447 and #1449. True diff: IvanIsCoding/rustworkx@pixi-pyodide...IvanIsCoding:rustworkx:test-pyodide
This builds on the preview two PRs by adding a Pixi task that does the following:
npm installto install Pyodidesmoke testthe full test suite inside Pyodide via Node.jsThis will catch regressions for Pyodide. Because Pixi has a lockfile and so does Node.js, I think it will be reproducible.
Note that Pyodide installs NumPy and more because it is one of our dependencies. We also need to install networkx. Because Pyodide has a lockfile internally (https://github.com/pyodide/pyodide-lock) that ships in the Node distribution, I think it will keep installing the same numpy/networkx/matplotlib from a fixed URL so I think overall this will be reproducible.