[Stable] Backport Ensure is_mergeable_with does not mutate TimeslotCollection #2639
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taalexander
approved these changes
Jun 14, 2019
mtreinish
approved these changes
Jun 14, 2019
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Within TimeslotCollections.is_mergeable_with(), checks if each slot.channel already exists in self._table. If the channel does not exist, it skips the rest of the check and moves on to the next timeslot in the TimeslotCollection. If the channel does exist, it continues to the Interval.has_overlap() function.
Details and comments
Backport of #2626