8000 [Stable] For each Acquire, create only one AcquireInstruction with all qubits by lcapelluto · Pull Request #2485 · Qiskit/qiskit · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[Stable] For each Acquire, create only one AcquireInstruction with all qubits #2485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 23, 2019
Merged

[Stable] For each Acquire, create only one AcquireInstruction with all qubits #2485

merged 1 commit into from
May 23, 2019

Conversation

lcapelluto
Copy link
Contributor

Summary

Fixes #2471

Details and comments

Join all converted acquire instructions (in qiskit/qobj/converters/pulse_instruction.py) into a single acquire instruction.

Backport of #2484.

@lcapelluto
For each Acquire, create only one AcquireInstruction with all qubits (Q…
e5e9129 
…iskit#2484)

* For each acquire PulseQobjInstruction, create only one AcquireInstruction for all involved qubits, rather than one per each qubit.

Add test

* update tests

* Small fixes -- make warning more descriptive
taalexander
taalexander approved these changes May 23, 2019
View reviewed changes
Copy link
Contributor
@taalexander taalexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. I have verified that it functions for acquires returned by backend.

@taalexander taalexander merged commit 328b060 into Qiskit:stable May 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taalexander taalexander taalexander approved these changes

@1ucian0 1ucian0 Awaiting requested review from 1ucian0

@ajavadia ajavadia Awaiting requested review from ajavadia

@atilag atilag Awaiting requested review from atilag

@chriseclectic chriseclectic Awaiting requested review from chriseclectic

@delapuente delapuente Awaiting requested review from delapuente

@diego-plan9 diego-plan9 Awaiting requested review from diego-plan9

@ewinston ewinston Awaiting requested review from ewinston

@jaygambetta jaygambetta Awaiting requested review from jaygambetta

@kdk kdk Awaiting requested review from kdk

@mtreinish mtreinish Awaiting requested review from mtreinish

@nonhermitian nonhermitian Awaiting requested review from nonhermitian

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lcapelluto @taalexander
0