socket connection is not terminated on closing window, when client.create() is called from browser process. #40

ssreekanth · 2016-05-19T23:54:15Z

Single Window Scenario : This is mostly applicable to OS X, where app.quit() is not called on window-all-closed event (as a result of second bullet point in Step 1 below). On other platforms, app.quit() gets called, which would force close the socket connection.

Multiple Window Scenario : The issue can be seen, when any of the multiple windows is closed.

Steps to recreate the issue

As shown in the code below, make sure the following are done.

call client.create() in the browser process (app.js)
on app window-all-closed event, make sure app.quit() is not called on OS X.
on window close event, set window handle to null.

app.js

'use strict';

var electron = require('electron');
var app = electron.app;
var BrowserWindow = electron.BrowserWindow;
var client = require('../../').client;

app.on('window-all-closed', function () {
  if (process.platform != 'darwin') {
    app.quit();
  }
});

app.on('ready', function () {
  console.log(process.argv.join(', '));
  console.log('Hello, browser process');
  var mainWindow = new BrowserWindow({
    width: 400,
    height: 300
  });

  mainWindow.loadURL('file://' + __dirname + '/index.html');

  mainWindow.on('closed', function() {
    mainWindow = null;
  });

  client.create(mainWindow);
});

index.html

<!DOCTYPE html>
<html lang="en">
<head>
  <meta charset="UTF-8">
  <title>Simple example app</title>
</head>
<body>
<h1>Hello, Electron</h1>
<script src="index.js"></script>
</body>
</html>

Run gulp serve command.
Close the window.

Expected Behavior

this.close() gets called and socket is terminated.

Actual Behavior

beforeunload event handler is not getting invoked. Hence, socket doesn't get terminated.

The text was updated successfully, but these errors were encountered:

fix issue #40

ssreekanth added a commit to ssreekanth/electron-connect that referenced this issue Jun 5, 2016

fix Quramy#40

ab796a8

ssreekanth added a commit to ssreekanth/electron-connect that referenced this issue Jun 5, 2016

add example for verifying issue Quramy#40

02d9ddb

ssreekanth changed the title ~~'beforeunload' event handler in client.js not getting invoked, when client.create() is called from browser process.~~ socket connection is not getting closed, when client.create() is called from browser process. Jun 5, 2016

ssreekanth mentioned this issue Jun 5, 2016

fix issue #40 #44

Merged

ssreekanth changed the title ~~socket connection is not getting closed, when client.create() is called from browser process.~~ socket connection is not terminated on closing window, when client.create() is called from browser process. Jun 7, 2016

ssreekanth added a commit to ssreekanth/electron-connect that referenced this issue Jun 10, 2016

add example code to verify issue Quramy#40

68830ee

Quramy closed this as completed in #44 Aug 13, 2016

Quramy added a commit that referenced this issue Aug 13, 2016

Merge pull request #44 from ssreekanth/master

81dad1b

fix issue #40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

socket connection is not terminated on closing window, when client.create() is called from browser process. #40

socket connection is not terminated on closing window, when client.create() is called from browser process. #40

socket connection is not terminated on closing window, when client.create() is called from browser process. #40

socket connection is not terminated on closing window, when client.create() is called from browser process. #40

Comments

Uh oh!

Steps to recreate the issue

Expected Behavior

Actual Behavior