8000 [SwiftLint] Enable type_name rule by ikesyo · Pull Request #967 · Quick/Quick · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[SwiftLint] Enable type_name rule #967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2020
Merged

[SwiftLint] Enable type_name rule #967

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .swiftlint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
disabled_rules:
- line_length
- type_name
- function_body_length
- identifier_name
included:
Expand Down
2 changes: 2 additions & 0 deletions Sources/Quick/Callsite.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,12 @@
import Foundation

#if canImport(Darwin)
// swiftlint:disable type_name
@objcMembers
public class _CallsiteBase: NSObject {}
#else
public class _CallsiteBase: NSObject {}
// swiftlint:enable type_name
#endif

// Ideally we would always use `StaticString` as the type for tracking the file name
Expand Down
2 changes: 2 additions & 0 deletions Sources/Quick/Example.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,12 @@
import Foundation

#if canImport(Darwin)
// swiftlint:disable type_name
@objcMembers
public class _ExampleBase: NSObject {}
#else
public class _ExampleBase: NSObject {}
// swiftlint:enable type_name
#endif

/**
Expand Down
2 changes: 2 additions & 0 deletions Sources/Quick/ExampleMetadata.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,12 @@
import Foundation

#if canImport(Darwin)
// swiftlint:disable type_name
@objcMembers
public class _ExampleMetadataBase: NSObject {}
#else
public class _ExampleMetadataBase: NSObject {}
// swiftlint:enable type_name
#endif

/**
Expand Down
2 changes: 2 additions & 0 deletions Sources/Quick/Filter.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,12 @@
import Foundation

#if canImport(Darwin)
// swiftlint:disable type_name
@objcMembers
public class _FilterBase: NSObject {}
#else
public class _FilterBase: NSObject {}
// swiftlint:enable type_name
#endif

/**
Expand Down
2 changes: 2 additions & 0 deletions Sources/Quick/World.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,12 @@ public typealias SharedExampleContext = () -> [String: Any]
public typealias SharedExampleClosure = (@escaping SharedExampleContext) -> Void

#if canImport(Darwin)
// swiftlint:disable type_name
@objcMembers
internal class _WorldBase: NSObject {}
#else
internal class _WorldBase: NSObject {}
// swiftlint:enable type_name
#endif

/**
Expand Down
2 changes: 2 additions & 0 deletions Tests/.swiftlint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
disabled_rules:
- type_name
0