Fix a test failure occurred in Xcode 9 beta #730
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `XCTestRun.totalFailureCount` instead of `failureCount`. It seems that in Xcode 9, `unexpectedExceptionCount` (and thus `totalFailureCount`) collects desired failure count.
|
LGTM. Does that mean that |
modocache
approved these changes
Jul 28, 2017
|
Thanks @modocache!
Not necessarily. I'm trying to support both Xcode 8.3 and Xcode 9 for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
XCTestRun.totalFailureCountinstead offailureCount. It seems that in Xcode 9,unexpectedExceptionCount(and thustotalFailureCount) collects desired failure count.https://developer.apple.com/documentation/xctest/xctestrun/1449657-totalfailurecount#