8000 Enable Swift 3 compatibility mode under Swift 4 by sharplet · Pull Request #711 · Quick/Quick · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Enable Swift 3 compatibility mode under Swift 4 #711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 14, 2017
Merged

Enable Swift 3 compatibility mode under Swift 4 #711

merged 3 commits into from
Jun 14, 2017

Conversation

sharplet
Copy link
Contributor
@sharplet sharplet commented Jun 3, 2017

See Quick/Nimble#431.

Ideally we should wait for the next Nimble patch release before merging (to avoid pinning Externals/Nimble to a branch).

@sharplet sharplet force-pushed the as-swift-4-swift-3-compat branch from c06dafd to 2f97bcf Compare June 9, 2017 13:35
@sharplet
Copy link
Contributor Author
sharplet commented Jun 9, 2017

Switched to Nimble 7.0.1, hopefully everything is green 🤞

@sharplet sharplet mentioned this pull request Jun 9, 2017
Merged
@sharplet
Copy link
Contributor Author
sharplet commented Jun 9, 2017

🍏 📗 💚 🥗 🇬🇱

@sharplet
Copy link
Contributor 8000 Author
sharplet commented Jun 9, 2017

Just manually verified that this builds and runs on Xcode 9, although there's a single test failure. 🤔

I don't think that needs to block a patch release though.

ikesyo
ikesyo reviewed Jun 14, 2017
View reviewed changes
Quick.xcodeproj/project.pbxproj Outdated
@@ -2400,6 +2400,7 @@
MACOSX_DEPLOYMENT_TARGET = 10.9;
METAL_ENABLE_DEBUG_INFO = YES;
ONLY_ACTIVE_ARCH = YES;
OTHER_SWIFT_FLAGS = "$(inherited) -swift-version 3";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please remove this since this is not needed (Quick/Nimble#437)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done 👍

@sharplet sharplet force-pushed the as-swift-4-swift-3-compat branch from 2f97bcf to 8250d93 Compare June 14, 2017 12:58
@sharplet
Copy link
Contributor Author

I think this should be ready to merge now.

@modocache modocache merged commit 5f0b899 into master Jun 14, 2017
@ikesyo ikesyo deleted the as-swift-4-swift-3-compat branch June 14, 2017 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ikesyo ikesyo ikesyo left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sharplet @ikesyo @modocache
0