8000 [QuickSpecBase] Fix SwiftPM integration with generated Xcode projects by ikesyo · Pull Request #708 · Quick/Quick · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[QuickSpecBase] Fix SwiftPM integration with generated Xcode projects #708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 16, 2017
Merged

[QuickSpecBase] Fix SwiftPM integration with generated Xcode projects #708

merged 1 commit into from
May 16, 2017

Conversation

ikesyo
Copy link
Member
@ikesyo ikesyo commented May 9, 2017

Let's use #import <Foundation/Foundation.h> instead of @import Foundation;.

Should fix #707.

@ikesyo
[QuickSpecBase] Fix SwiftPM integration with generated Xcode projects
2e63a9a 
Let's use `#import <Foundation/Foundation.h>` instead of `@import Foundation;`.
@ikesyo ikesyo mentioned this pull request May 9, 2017
Closed
@QuickBot
Copy link
QuickBot commented May 9, 2017
1 Warning
⚠️ Need to add an unit test if you’re modifying swift source

Generated by 🚫 danger

@jeffh jeffh merged commit 7b5bc39 into master May 16, 2017
@jeffh jeffh deleted the fix-swiftpm-integration-with-generated-xcode-projects branch May 16, 2017 07:42
@jeffh
Copy link
Member
jeffh commented May 16, 2017

Thanks @ikesyo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build error when using Quick with Swift Package Manager: Use of '@import' when modules are disabled
3 participants
@ikesyo @QuickBot @jeffh
0