8000 QuickSpec tests are not referenced in Xcode13.3 · Issue #1123 · Quick/Quick · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

QuickSpec tests are not referenced in Xcode13.3 #1123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
1 task done
nnsnodnb opened this issue Mar 16, 2022 · 16 comments
Closed
1 task done

QuickSpec tests are not referenced in Xcode13.3 #1123

nnsnodnb opened this issue Mar 16, 2022 · 16 comments
Labels
bug
Milestone
v5.0.0

Comments

@nnsnodnb
Copy link
  • I have read CONTRIBUTING and have done my best to follow them.

What did you do?

QuickSpec tests were not eligible for execution in Xcode 13.3.

All tests are correctly recognized when installed with the Swift Package Manager.
But when installed with CocoaPods, all tests are ignored.

What did you expect to happen?

Tests are executed.

What actually happened instead?

All tests were ignored.

Environment

List the software versions you're using:

  • Quick: 4.0.0
  • Nimble: ?.?.? not included
  • Xcode Version: 13.3 (13E113) (Open Xcode; In menubar: Xcode > About Xcode)
  • Swift Version: 5.6 use Xcode Default (Open Xcode Preferences; Components > Toolchains. If none, use Xcode Default.)

Please also mention which package manager you used and its version. Delete the
other package managers in this list:

  • CocoaPods: 1.11.3 (Use pod --version in Terminal)
  • Carthage: ?.? (Use carthage version in Terminal) not included
  • Swift Package Manager 5.6.0 (swiftpm-???) (Use swift build --version in Terminal)

Project that demonstrates the issue

Sample.zip
@mimibuduo123
Copy link

Xcode13.3 testInvocations -> testBundleWillStart

@mimibuduo123
Copy link

< Xcode13.3 testBundleWillStart < testInvocations

@paweldudek
Copy link

We did a quick & dirty fix this way: toptal@8c332c4

But I also don't know what are the ramifications of building examples right before they're run (this also is slightly inefficient b/c the code to build examples is run before every test - there's an internal check that prevents from duplicating tests for each class but the check needs to be run for every test - not the best complexity here 😕).

Would be nice for someone from Core team to chime in with direction, I can work out the details & submit a PR 🙌🏻

mimibuduo123 pushed a commit to mimibuduo123/Quick that referenced this issue Mar 16, 2022
Fix XCTest lifecycle in Xcode13.3 (Quick#1123)
1604d4c
@mimibuduo123 mimibuduo123 mentioned this issue Mar 16, 2022
Closed
4 tasks
@bspinner
Copy link

We did a quick & dirty fix this way: toptal@8c332c4

So others don't have to look it up...
You can (temporarily) use the referenced version by putting this into your Podfile:

pod 'Quick' , :git => 'https://github.com/toptal/Quick.git', :commit => '8c332c41770d87e62718531ed0951763c58f2345'

When you've done so, just run pod install --repo-update, rebuild your project and the tests will reappear.

@ignotusverum
Copy link

Adding Execute in parallel(if possible) flag in test scheme options - for unknown reason fixes issue with execution

Screen Shot 2022-03-22 at 5 43 58 PM

@ghost
Copy link
ghost commented Mar 23, 2022 •
edited by ghost
Loading

the @ignotusverum solution worked for me as well, thank you :)

skywalkerdude added a commit to HymnalDreamTeam/Hymns-iOS that referenced this issue Mar 23, 2022
@skywalkerdude
Change HymnsTest to run in parallel to fix Quick per Quick/Quick#1123…
9740ecf 
… (comment)
skywalkerdude added a commit to HymnalDreamTeam/Hymns-iOS that referenced this issue Mar 23, 2022
@skywalkerdude
Change HymnsTest to run in parallel to fix Quick per Quick/Quick#1123…
7459694 
… (comment)
@BobCatC BobCatC mentioned this issue Mar 27, 2022
Closed
@BobCatC
Copy link
Contributor
BobCatC commented Mar 29, 2022

Created a PR with a fix so reviewers are welcome 😄
There is also a question for @ikesyo , answer on which might help simplify the solution

@joeljfischer joeljfischer mentioned this issue Mar 30, 2022
Closed
@rbhuvizeli
Copy link

What do you think, when it'll be merged?
The Danger check failed. What should be done to merge that PR?

@BobCatC
Copy link
Contributor
BobCatC commented Mar 31, 2022

@rbhuvizeli, unfortunately the PR still has not been reviewed by developers of Quick, so when it will be merged I cannot answer.

About Danger check failure: looks like it's a problem of access to this repo (which I don't have of course). There is some text like "forbidden, 403 access error when posting a comment to issue (pr)". If someone has any idea how to fix this check failure - write it here or in PR.
image

@tropicalappspoland
Copy link

Come on, this is critical issue :(

@danielbarela
Copy link

Why has this not been merged in? We are unable to run tests in 13.3

@jessesquires
Copy link
Member

About Danger check failure: looks like it's a problem of access to this repo (which I don't have of course). There is some text like "forbidden, 403 access error when posting a comment to issue (pr)". If someone has any idea how to fix this check failure - write it here or in PR.

This is because Danger is run via GitHub Actions and your PR is a fork. Forks have different permissions/restrictions.

This is terrible design and a known flaw with GH Actions. 🤷🏼

@BobCatC BobCatC mentioned this issue Apr 5, 2022
Merged
@jessesquires
Copy link
Member

Fixed in #1129

@BA00001
Copy link
BA00001 commented Apr 13, 2022

what's the exact solution for this Xcode 13.3+ test with no progress on Code Coverage?

@jessesquires jessesquires added this to the v5.0.0 milestone Apr 13, 2022
@BA00001
Copy link
BA00001 commented Apr 14, 2022

what's the exact solution for this Xcode 13.3+ test with no progress on Code Coverage?

@jessesquires so not yet released, am I right, it's in under development?

@jessesquires
Copy link
Member

Update

Hey all, as noted above, this fix has been merged. It will be included in the v5.0.0 release when that is ready. I'm working on getting that wrapped up as soon as I can.

In the meantime, you can point your Podfile to the commit on main that includes the fix, a0a5fc8.

pod 'Quick', :git => 'https://github.com/Quick/Quick', :commit => 'a0a5fc8'

I recommend "Watching Releases" for this repo to be notified when v5.0 is out.

Screen Shot 2022-04-14 at 10 15 20 AM

Once v5.0 is released, you can revert your Podfile to pod 'Quick', '~> 5.0'.

@Quick Quick locked as resolved and limited conversation to collaborators Apr 14, 2022
@jessesquires
Copy link
Member

https://github.com/Quick/Quick/releases/tag/v5.0.0

v5 is released. not yet in cocoapods but it will be soon.

in the meantime, you can now point your podfile to the v5.0.0 tag.

@jessesquires
Copy link
Member

Quick 5.0 is now in CocoaPods. Please update.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v5.0.0
Development

No branches or pull requests
0