8000 Override recordFailure on SwiftPM as well · Issue #888 · Quick/Quick · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Override recordFailure on SwiftPM as well #888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ikesyo opened this issue May 10, 2019 · 1 comment · Fixed by #990
Closed

Override recordFailure on SwiftPM as well #888

ikesyo opened this issue May 10, 2019 · 1 comment · Fixed by #990

Comments

@ikesyo
Copy link
Member
ikesyo commented May 10, 2019 •
edited
Loading

This could be achievable now due to #848 and #850.

Quick/Sources/QuickObjectiveC/QuickSpec.m

Lines 136 to 148 in 582afe7

- (void)recordFailureWithDescription:(NSString *)description
inFile:(NSString *)filePath
atLine:(NSUInteger)lineNumber
expected:(BOOL)expected {
if (self.example.isSharedExample) {
filePath = self.example.callsite.file;
lineNumber = self.example.callsite.line;
}
[currentSpec.testRun recordFailureWithDescription:description
inFile:filePath
atLine:lineNumber
expected:expected];
}

@ikesyo ikesyo mentioned this issue Mar 28, 2020
Closed
1 task
@ikesyo ikesyo mentioned this issue Jun 1, 2020
Merged
@ikesyo ikesyo linked a pull request Sep 24, 2020 that will close this issue
Delegate recordFailure to QuickSpec.current #990
Merged
@ikesyo
Copy link
Member Author
ikesyo commented Sep 24, 2020

Resolved by #990.

@ikesyo ikesyo closed this as completed Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Delegate recordFailure to QuickSpec.current Quick/Quick
1 participant
@ikesyo
0