8000 Support QuickSpec.current on Linux by ikesyo · Pull Request #850 · Quick/Quick · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Support QuickSpec.current on Linux #850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 12, 2019
Merged

Support QuickSpec.current on Linux #850

merged 1 commit into from
Apr 12, 2019

Conversation

ikesyo
Copy link
Member
@ikesyo ikesyo commented Apr 8, 2019

Ref: #645, #848

This is a preparation for #680 which uses QuickSpec.current.

  • Does this have tests? Already exists
  • Does this have documentation? Already exists
  • Does this break the public API (Requires major version bump)? No
  • Is this a new feature (Requires minor version bump)? Yes

ikesyo
ikesyo commented Apr 8, 2019
View reviewed changes
Tests/LinuxMain.swift
AfterSuiteTests.self,
Configuration_AfterEachSpec.self,
Configuration_BeforeEachSpec.self,
CurrentSpecTests.self,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is added.

ikesyo
ikesyo commented Apr 8, 2019
View reviewed changes
Tests/QuickTests/QuickTests/FunctionalTests/CurrentSpecTests.swift
#if canImport(Darwin)
return result.replacingOccurrences(of: "_", with: " ")
#else
return result
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because we don't use example name to selector name conversion on Linux (there is no Objective-C runtime off-course 😃), we don't need to care about whether white spaces are used or not in example names.

@ikesyo ikesyo requested review from a team and removed request for a team April 8, 2019 01:24
@ikesyo
Copy link
Member Author
ikesyo commented Apr 12, 2019

Please let me go.

@ikesyo ikesyo merged commit 7e72757 into master Apr 12, 2019
@ikesyo ikesyo deleted the quickspec-current-swiftpm-linux branch April 12, 2019 14:11
@ikesyo ikesyo mentioned this pull request May 10, 2019
Closed
@ikesyo ikesyo mentioned this pull request Apr 6, 2020
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ikesyo
0