8000 Make the satisfyAllOf and satifyAnyOf matchers fail correctly when the submatchers fail by younata · Pull Request #860 · Quick/Nimble · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Make the satisfyAllOf and satifyAnyOf matchers fail correctly when the submatchers fail #860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 7, 2021
Merged

Make the satisfyAllOf and satifyAnyOf matchers fail correctly when the submatchers fail #860

merged 2 commits into from
May 7, 2021

Conversation

younata
Copy link
Member
@younata younata commented Feb 15, 2021 •
edited
Loading

I found that the satisfyAllOf and satisfyAnyOf matchers wouldn't correctly fail if there was a matcher than had returned status fail.

This changes both the satisfyAllOf and SatisfyAnyOf matchers to always fail, regardless of the result of the other submatchers, if any of the submodules returns with status fail. After failure, this will still run the rest of the matchers, just to get the correct error message.

The PR should summarize what was changed and why. Here are some questions to
help you if you're not sure:

  • What behavior was changed?
  • What code was refactored / updated to support this change?
  • What issues are related to this PR? Or why was this change introduced?

Checklist - While not every PR needs it, new features should consider this list:

  • Does this have tests?

ikesyo
ikesyo reviewed Apr 29, 2021
View reviewed changes
Copy link
Member
@ikesyo ikesyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be a bit simplified, but overall looks good! 👍

@ikesyo ikesyo added the bug label Apr 29, 2021
@younata @ikesyo
Apply suggestions from code review
96ef000 
Co-authored-by: IKEDA Sho <suicaicoca@gmail.com>
ikesyo
ikesyo approved these changes May 7, 2021
View reviewed changes
Copy link
Member
@ikesyo ikesyo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comme 822F nt to others. Learn more.

LGTM 👍

Thanks for catching/fixing this!

@ikesyo ikesyo merged commit 548c1f0 into Quick:master May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ikesyo ikesyo ikesyo approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@younata @ikesyo
0