10000 Introducing map keys discovering by pdelewski · Pull Request #1364 · QuesmaOrg/quesma · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Introducing map keys discovering #1364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 12, 2025
Merged

Introducing map keys discovering #1364

merged 4 commits into from
Mar 12, 2025

Conversation

pdelewski
Copy link
Contributor
@pdelewski pdelewski commented Mar 12, 2025 •
edited
Loading

This PR adds an automatic map key discovery feature needed for field caps and dashboard creation.

CREATE TABLE IF NOT EXISTS "foo"
(
    "@timestamp" DateTime64 DEFAULT now64(),
    `bar` Map(String, Nullable(String))
)
ENGINE = MergeTree
ORDER BY ("@timestamp");    

insert into foo values ('2020-01-01 00:00:00', {'a': 'b'});
insert into foo values ('2020-01-01 00:00:00', {'c': 'b'});
insert into foo values ('2020-01-01 00:00:00', {'e': 'b'});

Feature is hidden behind the global flag:

mapFieldsDiscoveringEnabled: true
image

@pdelewski pdelewski marked this pull request as ready for review March 12, 2025 13:24
@pdelewski pdelewski requested a review from a team as a code owner March 12, 2025 13:24
mieciu
mieciu approved these changes Mar 12, 2025
View reviewed changes
Copy link
Member
@mieciu mieciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@pdelewski pdelewski force-pushed the map-fields-discovering branch from d6a86fc to db11451 Compare March 12, 2025 13:54
@pdelewski pdelewski added this pull request to the merge queue Mar 12, 2025
Merged via the queue into main with commit 37b6fd8 Mar 12, 2025
6 checks passed
@pdelewski pdelewski deleted the map-fields-discovering branch March 12, 2025 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mieciu mieciu mieciu approved these changes

@nablaone nablaone Awaiting requested review from nablaone nablaone is a code owner automatically assigned from QuesmaOrg/engineering

@jakozaur jakozaur Awaiting requested review from jakozaur jakozaur is a code owner automatically assigned from QuesmaOrg/engineering

@stared stared Awaiting requested review from stared stared is a code owner automatically assigned from QuesmaOrg/engineering

@trzysiek trzysiek Awaiting requested review from trzysiek trzysiek is a code owner automatically assigned from QuesmaOrg/engineering

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pdelewski @mieciu
0