8000 Provide helper method to initiliaze a `MetaLearner` based on another `MetaLearner` by kklein · Pull Request #71 · Quantco/metalearners · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Provide helper method to initiliaze a MetaLearner based on another MetaLearner #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jul 25, 2024
Merged

Provide helper method to initiliaze a MetaLearner based on another MetaLearner #71

merged 9 commits into from
Jul 25, 2024

Conversation

kklein
Copy link
Collaborator
@kklein kklein commented Jul 24, 2024

Checklist

  • Added a CHANGELOG.rst entry

@kklein
Copy link
Collaborator Author
kklein commented Jul 24, 2024

@FrancescMartiEscofetQC does this make sense to you?

@FrancescMartiEscofetQC
Copy link
Contributor
FrancescMartiEscofetQC commented Jul 24, 2024 •
edited
Loading

Yes! I think it can be useful for cloning metalearners.

FrancescMartiEscofetQC
FrancescMartiEscofetQC reviewed Jul 24, 2024
View reviewed changes
@kklein kklein changed the title Provide helper method to initialize a MetaLearner. Provide helper method to initiliaze a MetaLearner based on another MetaLearner Jul 24, 2024
@codecov Codecov
Copy link
codecov bot commented Jul 24, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.90%. Comparing base (2f428fb) to head (4cc4f68).
Report is 18 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #71      +/-   ##
==========================================
+ Coverage   94.88%   94.90%   +0.01%     
==========================================
  Files          15       15              
  Lines        1544     1550       +6     
==========================================
+ Hits         1465     1471       +6     
  Misses         79       79

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kklein kklein marked this pull request as ready for review July 25, 2024 06:29
FrancescMartiEscofetQC
FrancescMartiEscofetQC reviewed Jul 25, 2024
View reviewed changes
kklein and others added 2 commits July 25, 2024 12:23
@kklein @FrancescMartiEscofetQC
Update metalearners/metalearner.py
474c598 
Co-authored-by: Francesc Martí Escofet <154450563+FrancescMartiEscofetQC@users.noreply.github.com>
@kklein @FrancescMartiEscofetQC
Update metalearners/metalearner.py
4cc4f68 
Co-authored-by: Francesc Martí Escofet <154450563+FrancescMartiEscofetQC@users.noreply.github.com>
FrancescMartiEscofetQC
FrancescMartiEscofetQC approved these changes Jul 25, 2024
View reviewed changes
Copy link
Contributor
@FrancescMartiEscofetQC FrancescMartiEscofetQC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kklein kklein merged commit 3cad00e into main Jul 25, 2024
16 checks passed
@kklein kklein deleted the init_params branch July 25, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FrancescMartiEscofetQC FrancescMartiEscofetQC FrancescMartiEscofetQC approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kklein @FrancescMartiEscofetQC
0