fix(auth): use subtle for constant time key comparison, fix lower case key issue #526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR replaces a case-insensitive lowercase comparison with a constant-time key check, refines how the Authorization header is parsed, and adds tests for multiple bearer-scheme edge cases.
- Use
subtle::ConstantTimeEqfor secure API key comparison - Parse and validate the "Bearer " scheme more precisely
- Add comprehensive tests for valid, invalid, missing, and malformed headers
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| crates/shared/src/security/api_key_middleware.rs | Import subtle, implement constant-time comparison, refine parsing, and add tests |
| crates/shared/Cargo.toml | Add subtle = "2.6.1" dependency |
Comments suppressed due to low confidence (1)
crates/shared/src/security/api_key_middleware.rs:60
- [nitpick] The nested
ifblocks lead to deep indentation. You could early-return on invalid conditions to flatten the logic, improving readability and reducing nesting.
if auth_str.len() > 7 {
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.