This repository was archived by the owner on Apr 26, 2024. It is now read-only.
allow new distributed versions starting with 2023.6.0 #117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrbourbeau
reviewed
Aug 30, 2023
There was a problem hiding this comment.
@serinamarie over in #115 it was suggested that you might be the right person to look at this. If that's not the case, do you know how might be?
|
cc @desertaxle |
serinamarie
reviewed
Aug 30, 2023
| @@ -1,3 +1,3 @@ | |||
| prefect>=2.8.2 | |||
| distributed==2022.2.0; python_version < '3.8' | |||
| distributed>=2022.5.0,<=2023.3.1; python_version >= '3.8' # upper bound due to issue with get_client starting in 2023.3.2 - https://github.com/dask/distributed/issues/7763 | |||
| distributed>=2022.5.0,!=2023.3.2,!=2023.3.2.1,!=2023.4.*,!=2023.5.*; python_version >= '3.8' # don't allow versions from 2023.3.2 to 2023.5 (inclusive) due to issue with get_client starting in 2023.3.2 (fixed in 2023.6.0) - https://github.com/dask/distributed/issues/7763 | |||
There was a problem hiding this comment.
I don't believe this excludes 2023.3.3 through < 2023.4.*
There was a problem hiding this comment.
2023.3.2.1 was the last distributed release in March
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #115 by still barring distributed versions with the problem, but removing the restriction for newer distributed versions.
Note that @zanieb confirmed on June 1 that the issue was fixed in distributed
mainbranch. Then the fix was included in the released 2023.6.0 on June 9.Specifically the change in this PR is:
<=2023.3.1restriction