8000 Update docs home page with license agreement by jlowin · Pull Request #147 · PrefectHQ/prefect · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update docs home page with license agreement #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 19, 2018
Merged

Update docs home page with license agreement #147

merged 5 commits into from
Aug 19, 2018

Conversation

jlowin
Copy link
Member
@jlowin jlowin commented Aug 19, 2018

No description provided.

@jlowin jlowin requested a review from cicdw as a code owner August 19, 2018 15:29
cicdw
cicdw previously approved these changes Aug 19, 2018
Copy link
Member
@cicdw cicdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

docs/README.md Outdated

```python
from prefect import task, Flow

@task
def say_hello():
print("Hello, world!")
print("Hello, world! 👋")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI emojis mess up my terminal

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove it?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, I think for the code examples, just in case.

@jlowin jlowin merged commit 813f17d into master Aug 19, 2018
@jlowin jlowin deleted the docs-home branch August 19, 2018 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0