Fix agent printing too often while thinking #1172
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR reduces the frequency of agent prints during thinking by coarsening the timestamp resolution used in the stable event ID.
- Changed timestamp granularity from full ISO format to hour-level only
- Affects how event IDs are generated to prevent repeated prints within the same hour
Comments suppressed due to low confidence (2)
src/marvin/handlers/print_handler.py:233
- Add a comment explaining why the timestamp is truncated to the hour (e.g., to batch prints within the same hour), so future readers understand the rationale.
msg_time = event.timestamp.isoformat(timespec='hour')
src/marvin/handlers/print_handler.py:233
- Add a unit test to verify that events within the same hour produce the same
event_idand that events in different hours produce distinct IDs.
msg_time = event.timestamp.isoformat(timespec='hour')
zzstoatzz
approved these changes
Jun 17, 2025
zzstoatzz
reviewed
Jun 17, 2025
|
actually @wreed4 can you share what model / setup you have here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes the logic in the print handler allowing thinking events to print within the same panel. Without this logic, Marvin would make a new panel if thinking events were even a millisecond apart, which happens quite frequently 😉.