Fix cpp building cmake #961
Conversation
add LIBRARY_BUILD_TYPE to portaudiocpp
|
I am not a CMake expert. But would it be better to just build BOTH libraries using something like: add_library(portaudiocpp_shared SHARED ${portaudiocpp-sources}) |
|
I am not a CMake expert, but I think we need to go back to building both static and shared libs in the main PortAudio cmakelists. It is a regression that this functionality was removed, see and other related tickets: https://github.com/PortAudio/portaudio/issues?q=is%3Aissue+is%3Aopen+label%3Abuild-cmake |
|
This issue needs to be fixed but we're not currently convinced that this is the correct fix. Hence assigning low priority to this PR. It would be good if someone can create an issue to track the actual bug that this PR is supposed to fix (i.e. the specific problem building the C++ binding). |
|
Removing from milestone. No response for 6 minths. We have no maintainers for Cmake. We have not received any help in understanding whether this is the correct fix. Happy to contine the discussion, but this can't hold up releases. |
|
@RossBencina I can handle this question but in a different way. I already checked how C++ bindings are built and currently it is overly complicated - building C++ lib is detached from building of the main PA library. I can't build C++ bindings easily on Windows with MSVC currently as I propose to simplify building C++ bindings by making them a byproduct of building the PA library. In this way CMake interface will provide an option to build C++ buildings If you are ok with this approach I will develop a PR for further discussion and integration. Please let me know your opinion. |
add LIBRARY_BUILD_TYPE to portaudiocpp
Need for fix static build as subproject (thrid-party)