chore: add field to Surveys to allow external responses #33994
Conversation
There was a problem hiding this comment.
PR Summary
Added a new nullable boolean field is_publicly_shareable to the Survey model to enable external survey access without authentication, defaulting to false for security.
- Added field
is_publicly_shareabletoSurveymodel inposthog/models/surveys/survey.py - Created migration file
0775_survey_is_publicly_shareable.pyfollowing Django patterns - Updated frontend Survey interface in
frontend/src/types.tsto include the new field - Migration follows security-first principle by defaulting to false to maintain surveys as private by default
4 files reviewed, 1 comment
Edit PR Review Bot Settings | Greptile
|
Size Change: 0 B Total Size: 2.58 MB ℹ️ View Unchanged
|
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted: Caution Detected flapping snapshotsThese snapshots have auto-updated more than once since the last human commit:
The flippy-flappies are deadly and must be fixed ASAP. They're productivity killers.
Triggered by this commit. |
Migration SQL ChangesHey 👋, we've detected some migrations on this PR. Here's the SQL output for each migration, make sure they make sense:
|
Problem
Part of #33948.
Right now, surveys can only be answered as in-app. This field will gate surveys being accessible externally. No functionality changes here, just adding the migration.
Changes
adds the new field to Surveys model and proper migrations.
Did you write or update any docs for this change?
How did you test this code?
no funcionality changes