fix: makefile for posthog_analytics release #248
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
PR Summary
Updates the release process for the posthoganalytics package by improving the build system and file handling. These changes enhance reliability and maintainability.
- Modifies
setup_analytics.pyto dynamically update package metadata inpyproject.tomlinstead of duplicating configuration - Adds handling for
__pycache__directories inMakefileto prevent common build failures - Implements proper backup and restoration of
pyproject.tomlduring the analytics release process - Improves cleanup of build artifacts to ensure clean releases
2 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
+19
to
+20
| find ./posthoganalytics -type f -not -path "*/__pycache__/*" -exec sed -i '' -e 's/from posthog /from posthoganalytics /g' {} \; | ||
| find ./posthoganalytics -type f -not -path "*/__pycache__/*" -exec sed -i '' -e 's/from posthog\./from posthoganalytics\./g' {} \; |
There was a problem hiding this comment.
logic: The sed commands use the -i '' flag which is macOS-specific. This could cause issues on Linux systems.
Suggested change
| find ./posthoganalytics -type f -not -path "*/__pycache__/*" -exec sed -i '' -e 's/from posthog /from posthoganalytics /g' {} \; | |
| find ./posthoganalytics -type f -not -path "*/__pycache__/*" -exec sed -i '' -e 's/from posthog\./from posthoganalytics\./g' {} \; | |
| find ./posthoganalytics -type f -not -path "*/__pycache__/*" -exec sed -i.bak -e 's/from posthog /from posthoganalytics /g' {} \; && find ./posthoganalytics -name '*.bak' -delete | |
| find ./posthoganalytics -type f -not -path "*/__pycache__/*" -exec sed -i.bak -e 's/from posthog\./from posthoganalytics\./g' {} \; && find ./posthoganalytics -name '*.bak' -delete |
daibhin
approved these changes
Jun 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the posthog_analytics release was broken in the recent reorganisation of files