chore: new survey config #2031
Merged
chore: new survey config #2031
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ioannisj
approved these changes
Jun 20, 2025
3839770 to
1af43f5
Compare
|
Size Change: +1.64 kB (+0.05%) Total Size: 3.56 MB
ℹ️ View Unchanged
|
marandaneto
reviewed
Jun 23, 2025
| * | ||
| * @default false | ||
| */ | ||
| disable_surveys_automatic_display: boolean |
There was a problem hiding this comment.
It's already merged, but the name and description are confusing to me.
we have disable_surveys and disable_surveys_automatic_display
why would I chose disable_surveys_automatic_display over disable_surveys?
They do the same thing, I guess? I probably lack some context, and the user probably will too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adds a new setting,
disable_surveys_automatic_display. When this is true, no surveys will be shown automatically.Necessary for fullscreen surveys, so we don't trigger any surveys on that page.
Also fixes a small issue where we're automatically focusing the open text input even in the survey preview.