8000 Revert "fix: fix release workflow" by daibhin · Pull Request #2020 · PostHog/posthog-js · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Revert "fix: fix release workflow" #2020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jum 8000 p to bottom
Merged
merged 1 commit into from
Jun 16, 2025
Merged

Revert "fix: fix release workflow" #2020

merged 1 commit into from
Jun 16, 2025

Conversation

daibhin
Copy link
Contributor
@daibhin daibhin commented Jun 16, 2025

Reverts #2019

@vercel Vercel
Copy link
vercel bot commented Jun 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
posthog-js 🔄 Building (Inspect) Visit Preview Jun 16, 2025 11:07am

@daibhin daibhin merged commit 8f95e1a into main Jun 16, 2025
10 of 13 checks passed
@daibhin daibhin deleted the revert-2019-hp/fix-cd-workflow-2 branch June 16, 2025 11:07
daibhin added a commit that referenced this pull request Jun 16, 2025
@daibhin
Revert "Revert "remove custom eslint rules (#2019)" (#2020)"
1e722f6 
This reverts commit 8f95e1a.
greptile-apps[bot]
greptile-apps bot reviewed Jun 16, 2025
View reviewed changes
Copy link
Contributor
@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR reverts a previous change (#2019) to the release workflow, reinstating the 'test:custom-eslint-rules' script execution as part of the test suite in packages/browser/package.json.

  • Re-adds ESLint rule testing to the pre-release pipeline, strengthening quality checks before package deployment
  • Change affects the continuous deployment workflow by enforcing custom linting rules validation

1 file reviewed, no comments
Edit PR Review Bot Settings | Greptile

@github-actions GitHub Actions
Copy link

Download bundle size visualization

@github-actions GitHub Actions
Copy link

Size Change: 0 B

Total Size: 3.55 MB

ℹ️ View Unchanged
Filename Size
packages/browser/dist/all-external-dependencies.js 219 kB
packages/browser/dist/array.full.es5.js 305 kB
packages/browser/dist/array.full.js 370 kB
packages/browser/dist/array.full.no-external.js 387 kB
packages/browser/dist/array.js 170 kB
packages/browser/dist/array.no-external.js 185 kB
packages/browser/dist/customizations.full.js 11 kB
packages/browser/dist/dead-clicks-autocapture.js 12.6 kB
packages/browser/dist/exception-autocapture.js 9.55 kB
packages/browser/dist/external-scripts-loader.js 2.57 kB
packages/browser/dist/main.js 171 kB
packages/browser/dist/module.full.js 370 kB
packages/browser/dist/module.full.no-external.js 387 kB
packages/browser/dist/module.js 171 kB
packages/browser/dist/module.no-external.js 186 kB
packages/browser/dist/posthog-recorder.js 207 kB
packages/browser/dist/recorder-v2.js 113 kB
packages/browser/dist/recorder.js 113 kB
packages/browser/dist/surveys-preview.js 70.3 kB
packages/browser/dist/surveys.js 78.1 kB
packages/browser/dist/tracing-headers.js 1.58 kB
packages/browser/dist/web-vitals.js 10.4 kB

compressed-size-action

daibhin added a commit that referenced this pull request Jun 16, 2025
@daibhin
Revert "Revert "remove custom eslint rules (#2019)" (#2020)" (#2021)
92aa669
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greptile-apps greptile-apps[bot] greptile-apps[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@daibhin
0