Create offline mode accounts with consistent Uuids #1622
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses basically what already exists in Qt, just modified so I can specify an arbitrary length byte array for the namespace. Not really sure if it needs to be the same as the way Minecraft generates it or if I could've just used Uuid::createUuidV3. It would've still been consistent either way, but whatever, this works. Signed-off-by: Lenny McLennington <lenny@sneed.church>
ghost
approved these changes
Dec 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses basically what already exists in Qt, just modified so I can specify an arbitrary length byte array for the namespace. Not really sure if it needs to be the same as the way Minecraft generates it or if I could've just used Uuid::createUuidV3. It would've still been consistent either way, but whatever, this works.
Previously it would've just created a random Uuid as specified by https://doc.qt.io/qt-6/quuid.html#createUuid.
Now, it uses the same method briefly described in https://wiki.vg/Protocol#Login, example Java implementation of which is shown in https://gist.github.com/games647/615846434bfc08c2164349eefdd35d33.