fix hang when importing certain modpacks #1616
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modified findFolderOfFileInZip to use a breadth-first search and support searching for multiple file names in one pass. This should prevent or at least make it less likely to hang while importing certain packs. Signed-off-by: Lenny McLennington <lenny@sneed.church>
6fd7f23 to
e2875ef
Compare
| @@ -285,7 +285,7 @@ | |||
| 8000 | { | ||
| return; | |||
| } | |||
| auto location = MMCZip::findFolderOfFileInZip(&zip, "level.dat"); | |||
| auto [location, _] = MMCZip::findFolderOfFileInZip(&zip, {"level.dat"}); | |||
Check notice
Code scanning / CodeQL
Unused local variable
|
What modpacks suffer from this issue? |
|
Enigmatica 9 Expert is one of them, idk any others off the top of my head but people were saying it was happening with other packs too
13 Nov 2023 00:53:09 swirl ***@***.***>:
…
What modpacks suffer from this issue?
—
Reply to this email directly, view it on GitHub[#1616 (comment)], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AGXWSVOYHXCIMZQU5BFHCMTYEFVPFAVCNFSM6AAAAAA7IK4GZSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMBXGMYTOMBTG4].
You are receiving this because you authored the thread.[Tracking image][https://github.com/notifications/beacon/AGXWSVLNMYQSAZGDNC6HSNDYEFVPFA5CNFSM6AAAAAA7IK4GZSWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTLXF4C2.gif]
|
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified findFolderOfFileInZip to use a breadth-first search and support searching for multiple file names in one pass. This should prevent or at least make it less likely to hang while importing certain packs.