8000 fix: allow starting rd- versions by Scrumplex · Pull Request #1146 · PolyMC/PolyMC · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: allow starting rd- versions #1146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 15, 2022
Merged

fix: allow starting rd- versions #1146

merged 1 commit into from
Sep 15, 2022

Conversation

Scrumplex
Copy link
Contributor

Closes #1145

Using Collections.emptyList() doesn't allow us to later append stuff into that list. Use an empty ArrayList instead.

@Scrumplex
fix: allow starting rd- versions
684b8f2 
Using `Collections.emptyList()` doesn't allow us to later append stuff
into that list. Use an empty `ArrayList` instead.

Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
@Scrumplex Scrumplex added bug Something isn't working simple change This can be reviewed in mere minutes or even seconds labels Sep 15, 2022
@Scrumplex Scrumplex added this to the 5.0 milestone Sep 15, 2022
flowln
flowln approved these changes Sep 15, 2022
View reviewed changes
Copy link
Contributor
@flowln flowln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch!

@flowln flowln merged commit 8674ac4 into PolyMC:develop Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flowln flowln flowln approved these changes

@timoreo22 timoreo22 timoreo22 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working simple change This can be reviewed in mere minutes or even seconds
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.

Launching any rd pre-classic version fails with exception
3 participants
@Scrumplex @flowln @timoreo22
0