8000 Revert "Move classpath definition into NewLaunch itself" by Scrumplex · Pull Request #1111 · PolyMC/PolyMC · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Revert "Move classpath definition into NewLaunch itself" #1111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 5, 2022
Merged

Revert "Move classpath definition into NewLaunch itself" #1111

merged 1 commit into from
Sep 5, 2022

Conversation

Scrumplex
Copy link
Contributor

Reverts #1067

Closes #1101

I will see if I can get this to work later

@Scrumplex Scrumplex added the bug Something isn't working label Sep 5, 2022
@Scrumplex Scrumplex added this to the 5.0 milestone Sep 5, 2022
@Scrumplex
Copy link
Contributor Author

Oh right. GitHub doesn't allow me to change the commit message when creating a revert PR

@Scrumplex
Revert "Move classpath definition into NewLaunch itself"
1b559c7 
Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
@Scrumplex Scrumplex force-pushed the revert-1067-classpath-epicness branch from cb2e990 to 1b559c7 Compare September 5, 2022 15:37
timoreo22
timoreo22 approved these changes Sep 5, 2022
View reviewed changes
Copy link
Contributor
@timoreo22 timoreo22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Classpath epicness not being epic

flowln
flowln approved these changes Sep 5, 2022
View reviewed changes
Copy link
Contributor
@flowln flowln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rip

@DioEgizio
Copy link
Contributor

Merge?

@Scrumplex Scrumplex merged commit b70a82c into develop Sep 5, 2022
@Scrumplex Scrumplex deleted the revert-1067-classpath-epicness branch September 5, 2022 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flowln flowln flowln approved these changes

@timoreo22 timoreo22 timoreo22 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.

Bug when trying to start forge instance: No file detector is enabled
4 participants
@Scrumplex @DioEgizio @flowln @timoreo22
0