8000 Allow the cape to be changed without changing the skin by Gingeh · Pull Request #913 · PolyMC/PolyMC · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Allow the cape to be changed without changing the skin #913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 17, 2022
Merged

Allow the cape to be changed without changing the skin #913

merged 1 commit into from
Jul 17, 2022

Conversation

Gingeh
Copy link
Contributor
@Gingeh Gingeh commented Jul 15, 2022

Fixes #368 by making skin uploads optional.

If the skin upload box is empty, skin uploading is skipped. I have also added a placeholder to the text box explaining this to users.

I'm not entirely convinced this is a worthwhile change, but it's here if you want it I guess.

@Gingeh
Make skin upload optional
4dfc018 
Signed-off-by: Gingeh <39150378+Gingeh@users.noreply.github.com>
@Gingeh Gingeh force-pushed the cape-without-skin branch from 88e70fa to 4dfc018 Compare July 15, 2022 02:23
@txtsd txtsd self-requested a review July 15, 2022 19:26
Regular-Baf
Regular-Baf reviewed Jul 15, 2022
View reviewed changes
Copy link
Contributor
@Regular-Baf Regular-Baf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please merge I beg

flowln
flowln approved these changes Jul 16, 2022
View reviewed changes
Copy link
Contributor
@flowln flowln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@flowln flowln added the enhancement New feature or request label Jul 16, 2022
@Scrumplex Scrumplex added this to the 1.5.0 milestone Jul 16, 2022
Scrumplex
Scrumplex approved these changes Jul 16, 2022
View reviewed changes
Copy link
Contributor
@Scrumplex Scrumplex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks!

@Scrumplex
Copy link
Contributor

Let's cram this into 1.4.0 actually :D

@Scrumplex Scrumplex modified the milestones: 1.5.0, 1.4.0 Jul 16, 2022
@Scrumplex Scrumplex added the simple change This can be reviewed in mere minutes or even seconds label Jul 16, 2022
@DioEgizio
Copy link
Contributor

3 approvals 👀

@Scrumplex Scrumplex merged commit 5608531 into PolyMC:develop Jul 17, 2022
@Gingeh Gingeh deleted the cape-without-skin branch July 17, 2022 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Regular-Baf Regular-Baf Regular-Baf left review comments

@flowln flowln flowln approved these changes

@Scrumplex Scrumplex Scrumplex approved these changes

@timoreo22 timoreo22 timoreo22 approved these changes

@txtsd txtsd Awaiting requested review from txtsd

Assignees
No one assigned
Labels
enhancement New feature or request simple change This can be reviewed in mere minutes or even seconds
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.

Allow the cape to be changed without changing the skin
6 participants
@Gingeh @Scrumplex @DioEgizio @flowln @timoreo22 @Regular-Baf
0