Some small fixes and improvements to modpacks #839
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scrumplex
approved these changes
Jun 24, 2022
timoreo22
approved these changes
Jun 30, 2022
Apparently, when Qt sees an icon with the height smaller than the rest, with this option set, it will change the height of all other items to be that one, causing PolyMC#828. While we do lose some performance changing this option, the issue is gone, so :| Signed-off-by: flow <flowlnlnln@gmail.com>
This code is super :pofat: omg Signed-off-by: flow <flowlnlnln@gmail.com>
When you change a copy thinking you're changing the original data smh Signed-off-by: flow <flowlnlnln@gmail.com>
Signed-off-by: flow <flowlnlnln@gmail.com>
Signed-off-by: flow <flowlnlnln@gmail.com>
Having a blank instead of _anything_ is bad UX. Instead, even when there's not a valid version (most likely disabled redistribution), we show a message in the UI, to differentiate from the loading state. Signed-off-by: flow <flowlnlnln@gmail.com>
Preventing undefined behaviour hooray! :D Signed-off-by: flow <flowlnlnln@gmail.com>
d8c09b5 to
e5f6dc1
Compare
txtsd
approved these changes
Jul 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
95f7e1a fixes #828
0d4f1b6 improves a little bit the UX when importing a modpack
c295819 and 4a62cd0 improve the performance of Modrinth and Flame modpack browsing, respectively.
e3a453a fixes #619
5e2e73e is a temporary workaround for #697 (the part where it doesn't show anything if a modpack is opted out :p)
d8c09b5 prevents aborts in mod/modpack downloaders in some Qt configurations