8000 Fix duplicate name in window title by jn64 · Pull Request #811 · PolyMC/PolyMC · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix duplicate name in window title #811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 26, 2022
Merged

Fix duplicate name in window title #811

merged 2 commits into from
Jun 26, 2022

Conversation

jn64
Copy link
Contributor
@jn64 jn64 commented Jun 18, 2022 •
edited
Loading

Fixes #335

With this PR see latest #811 (comment)

  • The main window will be named Instances
  • The application display name will be PolyMC <version>

Note on Qt platform-specific behaviour

On Windows and Linux, Qt appends the display name to all window titles.

Screenshot of main window and Settings window on GNOME, with display name appended to window titles.

On macOS the display name is not appended to window titles.

Alternative option

The main window could be named simply PolyMC <version>.

This will make the main window title consistent across all 3 platforms. Win/Linux will not have it duplicated; see #811 (comment).

Please let me know if this is preferred and I'll update the PR.

Scrumplex
Scrumplex approved these changes Jun 18, 2022
View reviewed changes
Copy link
Contributor
@Scrumplex Scrumplex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Especially paired with #810 should be a good way to deal with this

@Scrumplex Scrumplex added this to the 1.4.0 milestone Jun 18, 2022
kthchew
kthchew reviewed Jun 18, 2022
View reviewed changes
flowln
flowln approved these changes Jun 20, 2022
View reviewed changes
Copy link
Contributor
@flowln flowln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'd prefer not having the "Instances" part, and just have it as "PolyMC - ...". Anyway, either one is fine by me. Thanks!

@jn64
Copy link
Contributor Author
jn64 commented Jun 20, 2022 •
edited
Loading

Ok, I think this will ruffle less feathers while addressing the original issue only.

To summarise:

  • Display name is PolyMC <version>
  • Main window title is display name (on all platforms)
  • Other window titles will have display name appended (on Win/Linux)

screenshot-polymc-fix-window-title-2

@ZekeZDev ZekeZDev merged commit 9cc235c into PolyMC:develop Jun 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luni3359 luni3359 luni3359 left review comments

@kthchew kthchew kthchew left review comments

@flowln flowln flowln approved these changes

@Scrumplex Scrumplex Scrumplex approved these changes

@ZekeZDev ZekeZDev ZekeZDev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.

Title bar has duplicated name.
6 participants
@jn64 @flowln @Scrumplex @luni3359 @kthchew @ZekeZDev
0