8000 Fix warnings reported by LGTM.com by Scrumplex · Pull Request #808 · PolyMC/PolyMC · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix warnings reported by LGTM.com #808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 c 8000 ommit into from
Jul 8, 2022
Merged

Fix warnings reported by LGTM.com #808

merged 1 commit into from
Jul 8, 2022

Conversation

Scrumplex
Copy link
Contributor

No description provided.

@Scrumplex Scrumplex added this to the 1.4.0 milestone Jun 17, 2022
@lgtm-com
Copy link
lgtm-com bot commented Jun 17, 2022

This pull request introduces 1 alert and fixes 7 when merging 9ec2606 into 03e454b - view on LGTM.com

new alerts:

  • 1 for FIXME comment

fixed alerts:

  • 4 for Throwing pointers
  • 1 for Resource not released in destructor
  • 1 for Constant return type on member
  • 1 for Comparison result is always the same

@Scrumplex
Copy link
Contributor Author

This pull request introduces 1 alert and fixes 7 when merging 9ec2606 into 03e454b - view on LGTM.com

new alerts:

* 1 for FIXME comment

fixed alerts:

* 4 for Throwing pointers

* 1 for Resource not released in destructor

* 1 for Constant return type on member

* 1 for Comparison result is always the same

You win some, you lose some

@RaptaG
Copy link
Contributor
RaptaG commented Jun 17, 2022

You win some, you lose some

… it’s all a game to me

< 8000 div class="">
txtsd
txtsd approved these changes Jul 8, 2022
View reviewed changes
Copy link
Contributor
@txtsd txtsd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Scrumplex Scrumplex merged commit e6fe701 into PolyMC:develop Jul 8, 2022
@Scrumplex Scrumplex deleted the fix-lgtm-warnings branch July 8, 2022 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@txtsd txtsd txtsd approved these changes

@flowln flowln flowln approved these changes

@ZekeZDev ZekeZDev ZekeZDev approved these changes

@LennyMcLennington LennyMcLennington Awaiting requested review from LennyMcLennington

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.
6 participants
@Scrumplex @RaptaG @txtsd @flowln @LennyMcLennington @ZekeZDev
0