8000 Add Performance related settings by Jan200101 · Pull Request #707 · PolyMC/PolyMC · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add Performance related settings #707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 6, 2022
Merged

Add Performance related settings #707

merged 2 commits into from
Jul 6, 2022

Conversation

Jan200101
Copy link
Contributor

Integrates support for Feral Gamemode, discrete GPU support for Mesa and the proprietary Nvidia driver and MangoHud support

closes #253

@txtsd txtsd self-requested a review June 4, 2022 06:19
@txtsd txtsd added the enhancement New feature or request label Jun 4, 2022
Scrumplex
Scrumplex reviewed Jun 4, 2022
View reviewed changes
Copy link
Contributor
@Scrumplex Scrumplex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. Thanks! :D

@Jan200101 Jan200101 requested a review from Scrumplex June 9, 2022 07:53
@Scrumplex Scrumplex added this to the 1.4.0 milestone Jun 11, 2022
Scrumplex
Scrumplex reviewed Jun 29, 2022
View reviewed changes
flowln
flowln approved these changes Jul 3, 2022
View reviewed changes
Copy link
Contributor
@flowln flowln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be cool if the options were disabled if the user didn't have the necessary packages installed (or if they don't have a discrete gpu), but maybe it's more trouble than it's worth to implement, so it's fine

thank u!

@Jan200101
Copy link
Contributor Author

it would be cool if the options were disabled if the user didn't have the necessary packages installed (or if they don't have a discrete gpu), but maybe it's more trouble than it's worth to implement, so it's fine

I am open to implement that if there is a good way to do it.

For gamemode we could simply query the current status and disable it if its an error code.

I don't know what would could be done for the discrete gpu.

@timoreo22
Copy link
Contributor

For the discrete gpu, an option would be using something like lspci (or using some of the GPLv2 licensed code that is in it)

lspci has the option -mm for "machine readable output" trying to search for "VGA comppatible controller" should list all gpus, if 2 or more are detected, it should be available

Relevant source code for it here

@Jan200101
Copy link
Contributor Author

For the discrete gpu, an option would be using something like lspci (or using some of the GPLv2 licensed code that is in it)

I don't think shelling out to lspci is the right way to do this.
We could copy the code if really needed but we will have to see

lspci has the option -mm for "machine readable output" trying to search for "VGA comppatible controller" should list all gpus, if 2 or more are detected, it should be available

This will probably cause false positives on Desktop Computers with a Dedicated GPU and integrated Graphics where the Dedicated GPU is the default.

@timoreo22
Copy link
Contributor

Personally when i have my dGPU as main gpu, the iGPU is disabled and replaced with a dummy device (that dosn't count)

@flowln
Copy link
Contributor
flowln commented Jul 3, 2022

PolyMC/launcher/minecraft/launch/PrintInstanceInfo.cpp

Line 38 in 6cd4375

void runLspci(QStringList &log)

i guess we already have lspci stuff lol :p

@DioEgizio
Copy link
Contributor
DioEgizio commented Jul 6, 2022 •
edited
Loading

For the discrete gpu, an option would be using something like lspci (or using some of the GPLv2 licensed code that is in it)

lspci has the option -mm for "machine readable output" trying to search for "VGA comppatible controller" should list all gpus, if 2 or more are detected, it should be available

Relevant source code for it here

Gpl2 isn't automatically compatible with the GPL3, and it's incompatible with gpl3 if there's no later version clause, like in this case

@Scrumplex
Copy link
Contributor

@Jan200101 You need to sign-off your commit. Otherwise we can't merge it. See https://github.com/PolyMC/PolyMC/pull/707/checks?check_run_id=7208080226

@Jan200101
Copy link
Contributor Author

That is annoying, will do in a second

Jan200101 and others added 2 commits July 6, 2022 09:34
@Jan200101
Add Performance related settings
cad5813 
Integrates support for Feral Gamemode, discrete GPU support for Mesa and the proprietary Nvidia driver and MangoHud support

Signed-off-by: Jan200101 <sentrycraft123@gmail.com>
@txtsd @Jan200101
chore(readme): Reword and place entry in alphabetical order
00df092 
Signed-off-by: txtsd <thexerothermicsclerodermoid@gmail.com>
@Scrumplex
Copy link
Contributor

Thanks!

@Scrumplex Scrumplex merged commit 04b865a into PolyMC:develop Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@txtsd txtsd txtsd approved these changes

@flowln flowln flowln approved these changes

@Scrumplex Scrumplex Scrumplex approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.

Toggleable options for MangoHud, PRIME and/or GameMode
6 participants
@Jan200101 @timoreo22 @flowln @DioEgizio @Scrumplex @txtsd
0