Multi-arch rules #680
Closed
Multi-arch rules #680
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There also is a few other issues with this pr like
All of that should probably be deleted and squashed out, otherwise the code looks fine |
yea definietly. The share is actually a symlink I did for CLION to not break, but it can be removed |
All fixed and updated to newest upstream |
ZekeZDev
approved these changes
Jun 2, 2022
1 task
d-513
suggested changes
Jun 2, 2022
d-513
approved these changes
Jun 2, 2022
|
I wouldn't call that a fix tbh. |
|
Yeah it's more a workaround |
Scrumplex
suggested changes
Jun 9, 2022
|
But why download useless libraries tho? Downloading arm on x86-64 doesn’t make sense |
Scrumplex
reviewed
Jun 9, 2022
Because you can't run arm natives with a x86-64 JRE. The point is, that you can't mix CPU architectures for a running application. If the user uses a x86-64 JRE, then they need x86-64 natives. |
Co-authored-by: Sefa Eyeoglu <contact@scrumplex.net>
Co-authored-by: Sefa Eyeoglu <contact@scrumplex.net>
Scrumplex
reviewed
Jul 1, 2022
Signed-off-by: Toshit Chawda <r58playz@gmail.com>
I, r58Playz <toshit307@gmail.com>, hereby add my Signed-off-by to this commit: 02b8588 Signed-off-by: r58Playz <toshit307@gmail.com>
…github.com> I, r58Playz <45221816+r58Playz@users.noreply.github.com>, hereby add my Signed-off-by to this commit: bd38a7c I, r58Playz <45221816+r58Playz@users.noreply.github.com>, hereby add my Signed-off-by to this commit: 9b6a878 I, r58Playz <45221816+r58Playz@users.noreply.github.com>, hereby add my Signed-off-by to this commit: cae505a Signed-off-by: r58Playz <45221816+r58Playz@users.noreply.github.com>
I, r58Playz <toshit307@gmail.com>, hereby add my Signed-off-by to this commit: ff122bb I, r58Playz <toshit307@gmail.com>, hereby add my Signed-off-by to this commit: e4a2972 I, r58Playz <toshit307@gmail.com>, hereby add my Signed-off-by to this commit: a207dff I, r58Playz <toshit307@gmail.com>, hereby add my Signed-off-by to this commit: e5ca5ff I, r58Playz <toshit307@gmail.com>, hereby add my Signed-off-by to this commit: 000f892 I, r58Playz <toshit307@gmail.com>, hereby add my Signed-off-by to this commit: a7140b3 I, r58Playz <toshit307@gmail.com>, hereby add my Signed-off-by to this commit: ea69d59 I, r58Playz <toshit307@gmail.com>, hereby add my Signed-off-by to this commit: 4d844e1 I, r58Playz <toshit307@gmail.com>, hereby add my Signed-off-by to this commit: d0c818d Signed-off-by: r58Playz <toshit307@gmail.com>
I, r58Playz <r58playz@gmail.com>, hereby add my Signed-off-by to this commit: e0068b6 I, r58Playz <r58playz@gmail.com>, hereby add my Signed-off-by to this commit: b67c7a2 I, r58Playz <r58playz@gmail.com>, hereby add my Signed-off-by to this commit: fc548e8 I, r58Playz <r58playz@gmail.com>, hereby add my Signed-off-by to this commit: ae15f6c Signed-off-by: r58Playz <r58playz@gmail.com>
that issue was fixed ages ago, just so you know |
I, r58Playz <toshit307@gmail.com>, hereby add my Signed-off-by to this commit: 02b8588 Signed-off-by: r58Playz <toshit307@gmail.com>
…oreply.github.com> I, r58Playz <45221816+r58Playz@users.noreply.github.com>, hereby add my Signed-off-by to this commit: bd38a7c I, r58Playz <45221816+r58Playz@users.noreply.github.com>, hereby add my Signed-off-by to this commit: 9b6a878 I, r58Playz <45221816+r58Playz@users.noreply.github.com>, hereby add my Signed-off-by to this commit: cae505a Signed-off-by: r58Playz <45221816+r58Playz@users.noreply.github.com>
I, r58Playz <toshit307@gmail.com>, hereby add my Signed-off-by to this commit: ff122bb I, r58Playz <toshit307@gmail.com>, hereby add my Signed-off-by to this commit: e4a2972 I, r58Playz <toshit307@gmail.com>, hereby add my Signed-off-by to this commit: a207dff I, r58Playz <toshit307@gmail.com>, hereby add my Signed-off-by to this commit: e5ca5ff I, r58Playz <toshit307@gmail.com>, hereby add my Signed-off-by to this commit: 000f892 I, r58Playz <toshit307@gmail.com>, hereby add my Signed-off-by to this commit: a7140b3 I, r58Playz <toshit307@gmail.com>, hereby add my Signed-off-by to this commit: ea69d59 I, r58Playz <toshit307@gmail.com>, hereby add my Signed-off-by to this commit: 4d844e1 I, r58Playz <toshit307@gmail.com>, hereby add my Signed-off-by to this commit: d0c818d Signed-off-by: r58Playz <toshit307@gmail.com>
I, r58Playz <r58playz@gmail.com>, hereby add my Signed-off-by to this commit: 864ae88 I, r58Playz <r58playz@gmail.com>, hereby add my Signed-off-by to this commit: e825f0b I, r58Playz <r58playz@gmail.com>, hereby add my Signed-off-by to this commit: 45ad5aa I, r58Playz <r58playz@gmail.com>, hereby add my Signed-off-by to this commit: 027d634 Signed-off-by: r58Playz <r58playz@gmail.com>
Signed-off-by: r58Playz <r58playz@gmail.com>
Signed-off-by: r58Playz <r58playz@gmail.com>
2975a20 Signed-off-by: r58Playz <r58playz@gmail.com>
|
Get scrumped |
|
Scrumped |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just #514 but updated to newest develop.
Works with PolyMC/meta-scripts#16 to provide multi-arch support.
edit: Fixes #382
edit 2: Fixes #765 but not really, just a workaroundfixed already