Merged view of usb and bluetooth devices #81
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abelfodil
approved these changes
Nov 15, 2020
WilliamHarvey97
requested changes
Nov 15, 2020
mobile/lib/src/presentation/pages/device_selector/device_selector_page.dart
Outdated
Show resolved
Hide resolved
| @@ -20,14 +21,21 @@ class SerialRepository implements IAcquisitionDeviceRepository { | |||
| void initializeRepository() { | |||
There was a problem hiding this comment.
Pourquoi ne pas nommer cela scan()? Même si ce n'est pas un scan bluetooth comme tel, je trouve que cela explique plus ce que c'est. Si on le nomme comme ça, on pourrait retourner Stream<List<AcquisitionDevice>> à la place de void. On aurait plus besoin de IAcquisitionDeviceRepository::watch() si on procédait ainsi.
mobile/lib/src/infrastructure/connection_repositories/acquisition_device_repository.dart
Outdated
Show resolved
Hide resolved
mobile/lib/src/infrastructure/connection_repositories/acquisition_device_repository.dart
Outdated
Show resolved
Hide resolved
mobile/lib/src/infrastructure/connection_repositories/acquisition_device_repository.dart
Outdated
Show resolved
Hide resolved
WilliamHarvey97
requested changes
Nov 15, 2020
mobile/lib/src/infrastructure/connection_repositories/bluetooth_repository.dart
Outdated
Show resolved
Hide resolved
WilliamHarvey97
approved these changes
Nov 19, 2020
mobile/lib/src/domain/acquisition_device/device_locator_service.dart
Outdated
Show resolved
Hide resolved
mobile/lib/src/infrastructure/connection_repositories/bluetooth_repository.dart
Outdated
Show resolved
Hide resolved
mobile/lib/src/infrastructure/connection_repositories/bluetooth_repository.dart
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Showing Usb and Bluetooth devices in the same view. Also fixed a bug where plugging in a Usb device after opening the page wouldn't show it.